Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support long-range dipole in linear spin wave theory #257

Merged
merged 29 commits into from
May 2, 2024
Merged

Support long-range dipole in linear spin wave theory #257

merged 29 commits into from
May 2, 2024

Conversation

kbarros
Copy link
Member

@kbarros kbarros commented Apr 29, 2024

No description provided.

@kbarros kbarros force-pushed the ewald branch 5 times, most recently from c976e18 to 590d900 Compare May 1, 2024 00:53
ddahlbom
ddahlbom approved these changes May 1, 2024
View reviewed changes
Copy link
Member

@ddahlbom ddahlbom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks fantastic. It's very nice you were able to reuse the existing Ewald calculator. I put a few minor comments in the code.

We may next want to discuss an interface for adding arbitrary J(q) interactions.

examples/07_Dipole_Dipole.jl Outdated Show resolved Hide resolved
src/SpinWaveTheory/HamiltonianDipole.jl Outdated Show resolved Hide resolved
src/System/Ewald.jl Outdated Show resolved Hide resolved
src/System/PairExchange.jl Outdated Show resolved Hide resolved
src/System/System.jl Outdated Show resolved Hide resolved
src/SpinWaveTheory/HamiltonianSUN.jl Show resolved Hide resolved
@kbarros
Copy link
Member Author

kbarros commented May 2, 2024

Thanks @ddahlbom for the helpful suggestions. The new commits address them.

@ddahlbom
Copy link
Member

ddahlbom commented May 2, 2024

Thanks, Kipton. Will be great to get this merged.

@kbarros kbarros merged commit 1c7cc3c into main May 2, 2024
4 checks passed
@kbarros kbarros deleted the ewald branch May 2, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddahlbom ddahlbom ddahlbom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kbarros @ddahlbom